Add bootstrap development guidelines #9821

PerfectSlayer · 2025-10-21T17:44:48Z

What Does This Do

This PR adds documentation about pitfalls and guideline implementation the agent bootstrap.
It also includes an addition about logging guidelines for instrumentations.

Motivation

The goal is to capture the knowledge so it would make it easier for contributors to avoid common pitfalls that might not be caught by testing.

Additional Notes

Refers to the discussions from both internal Slack channel and #9780

cc @mcculls who's the most knowledgeable about this part.
I would like to make sure I get it right. Feel free to edit the PR or add comment for me to amend the doc 🙏

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any useful labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the CODEOWNERS file on source file addition, move, or deletion
Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

github-actions · 2025-10-21T17:45:04Z

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

datadog-datadog-prod-us1 · 2025-10-21T17:50:06Z

🎯 Code Coverage
• Patch Coverage: 100.00%
• Total Coverage: 59.68% (+0.07%)

View detailed report

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: 61ad496 | Docs | Datadog PR Page | Was this helpful? Give us feedback!}

pr-commenter · 2025-10-21T18:06:26Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	bbujon/doc
git_commit_date	1762881452	1762931828
git_commit_sha	`5db793a`	`61ad496`
release_version	1.56.0-SNAPSHOT~5db793a092	1.55.0-SNAPSHOT~61ad496ab7

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1762933713	1762933713
ci_job_id	1229126313	1229126313
ci_pipeline_id	82042313	82042313
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-mt4o7zer 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-mt4o7zer 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None

Summary

Found 1 performance improvements and 1 performance regressions! Performance is the same for 50 metrics, 13 unstable metrics.

scenario	Δ mean execution_time	candidate mean execution_time	baseline mean execution_time
scenario:startup:insecure-bank:iast:Flare Poller	worse [+130.279µs; +315.272µs] or [+3.140%; +7.600%]	4.371ms	4.148ms
scenario:startup:insecure-bank:tracing:Remote Config	better [-52.709µs; -23.722µs] or [-7.301%; -3.286%]	683.692µs	721.907µs

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~61ad496ab7, baseline=1.56.0-SNAPSHOT~5db793a092

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.052 s) : 0, 1051659
Total [baseline] (10.955 s) : 0, 10955434
Agent [candidate] (1.029 s) : 0, 1029038
Total [candidate] (10.799 s) : 0, 10799047
section appsec
Agent [baseline] (1.224 s) : 0, 1223527
Total [baseline] (10.88 s) : 0, 10880470
Agent [candidate] (1.199 s) : 0, 1199232
Total [candidate] (10.87 s) : 0, 10870488
section iast
Agent [baseline] (1.18 s) : 0, 1179815
Total [baseline] (11.203 s) : 0, 11203061
Agent [candidate] (1.154 s) : 0, 1154262
Total [candidate] (11.125 s) : 0, 11125022
section profiling
Agent [baseline] (1.197 s) : 0, 1196931
Total [baseline] (10.93 s) : 0, 10930436
Agent [candidate] (1.183 s) : 0, 1182516
Total [candidate] (10.928 s) : 0, 10928094

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.052 s	-
Agent	appsec	1.224 s	171.868 ms (16.3%)
Agent	iast	1.18 s	128.156 ms (12.2%)
Agent	profiling	1.197 s	145.272 ms (13.8%)
Total	tracing	10.955 s	-
Total	appsec	10.88 s	-74.965 ms (-0.7%)
Total	iast	11.203 s	247.627 ms (2.3%)
Total	profiling	10.93 s	-24.998 ms (-0.2%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.029 s	-
Agent	appsec	1.199 s	170.194 ms (16.5%)
Agent	iast	1.154 s	125.224 ms (12.2%)
Agent	profiling	1.183 s	153.477 ms (14.9%)
Total	tracing	10.799 s	-
Total	appsec	10.87 s	71.44 ms (0.7%)
Total	iast	11.125 s	325.975 ms (3.0%)
Total	profiling	10.928 s	129.046 ms (1.2%)

gantt
    title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~61ad496ab7, baseline=1.56.0-SNAPSHOT~5db793a092

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.463 ms) : 0, 1463
crashtracking [candidate] (1.472 ms) : 0, 1472
BytebuddyAgent [baseline] (708.015 ms) : 0, 708015
BytebuddyAgent [candidate] (700.99 ms) : 0, 700990
GlobalTracer [baseline] (246.763 ms) : 0, 246763
GlobalTracer [candidate] (245.699 ms) : 0, 245699
AppSec [baseline] (32.324 ms) : 0, 32324
AppSec [candidate] (32.783 ms) : 0, 32783
Debugger [baseline] (6.427 ms) : 0, 6427
Debugger [candidate] (6.416 ms) : 0, 6416
Remote Config [baseline] (735.464 µs) : 0, 735
Remote Config [candidate] (681.468 µs) : 0, 681
Telemetry [baseline] (15.397 ms) : 0, 15397
Telemetry [candidate] (9.411 ms) : 0, 9411
Flare Poller [baseline] (5.709 ms) : 0, 5709
Flare Poller [candidate] (10.228 ms) : 0, 10228
section appsec
crashtracking [baseline] (1.466 ms) : 0, 1466
crashtracking [candidate] (1.455 ms) : 0, 1455
BytebuddyAgent [baseline] (729.892 ms) : 0, 729892
BytebuddyAgent [candidate] (720.641 ms) : 0, 720641
GlobalTracer [baseline] (238.023 ms) : 0, 238023
GlobalTracer [candidate] (236.051 ms) : 0, 236051
AppSec [baseline] (175.133 ms) : 0, 175133
AppSec [candidate] (175.589 ms) : 0, 175589
Debugger [baseline] (5.992 ms) : 0, 5992
Debugger [candidate] (6.069 ms) : 0, 6069
Remote Config [baseline] (658.413 µs) : 0, 658
Remote Config [candidate] (632.686 µs) : 0, 633
Telemetry [baseline] (8.566 ms) : 0, 8566
Telemetry [candidate] (8.609 ms) : 0, 8609
Flare Poller [baseline] (3.99 ms) : 0, 3990
Flare Poller [candidate] (3.893 ms) : 0, 3893
IAST [baseline] (24.829 ms) : 0, 24829
IAST [candidate] (25.036 ms) : 0, 25036
section iast
crashtracking [baseline] (1.461 ms) : 0, 1461
crashtracking [candidate] (1.471 ms) : 0, 1471
BytebuddyAgent [baseline] (828.608 ms) : 0, 828608
BytebuddyAgent [candidate] (816.547 ms) : 0, 816547
GlobalTracer [baseline] (234.844 ms) : 0, 234844
GlobalTracer [candidate] (232.336 ms) : 0, 232336
AppSec [baseline] (30.407 ms) : 0, 30407
AppSec [candidate] (35.779 ms) : 0, 35779
Debugger [baseline] (5.973 ms) : 0, 5973
Debugger [candidate] (6.229 ms) : 0, 6229
Remote Config [baseline] (601.21 µs) : 0, 601
Remote Config [candidate] (611.981 µs) : 0, 612
Telemetry [baseline] (8.428 ms) : 0, 8428
Telemetry [candidate] (8.82 ms) : 0, 8820
Flare Poller [baseline] (4.123 ms) : 0, 4123
Flare Poller [candidate] (4.306 ms) : 0, 4306
IAST [baseline] (30.619 ms) : 0, 30619
IAST [candidate] (26.703 ms) : 0, 26703
section profiling
ProfilingAgent [baseline] (111.669 ms) : 0, 111669
ProfilingAgent [candidate] (110.897 ms) : 0, 110897
crashtracking [baseline] (1.457 ms) : 0, 1457
crashtracking [candidate] (1.483 ms) : 0, 1483
BytebuddyAgent [baseline] (731.455 ms) : 0, 731455
BytebuddyAgent [candidate] (732.843 ms) : 0, 732843
GlobalTracer [baseline] (222.401 ms) : 0, 222401
GlobalTracer [candidate] (222.076 ms) : 0, 222076
AppSec [baseline] (32.176 ms) : 0, 32176
AppSec [candidate] (32.831 ms) : 0, 32831
Debugger [baseline] (7.474 ms) : 0, 7474
Debugger [candidate] (7.586 ms) : 0, 7586
Remote Config [baseline] (717.413 µs) : 0, 717
Remote Config [candidate] (697.489 µs) : 0, 697
Telemetry [baseline] (15.551 ms) : 0, 15551
Telemetry [candidate] (13.644 ms) : 0, 13644
Flare Poller [baseline] (4.115 ms) : 0, 4115
Flare Poller [candidate] (5.756 ms) : 0, 5756
Profiling [baseline] (112.335 ms) : 0, 112335
Profiling [candidate] (111.544 ms) : 0, 111544

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~61ad496ab7, baseline=1.56.0-SNAPSHOT~5db793a092

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.057 s) : 0, 1056998
Total [baseline] (8.675 s) : 0, 8675211
Agent [candidate] (1.027 s) : 0, 1026871
Total [candidate] (8.7 s) : 0, 8699688
section iast
Agent [baseline] (1.188 s) : 0, 1188164
Total [baseline] (9.337 s) : 0, 9336808
Agent [candidate] (1.156 s) : 0, 1156410
Total [candidate] (9.325 s) : 0, 9325330

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.057 s	-
Agent	iast	1.188 s	131.166 ms (12.4%)
Total	tracing	8.675 s	-
Total	iast	9.337 s	661.597 ms (7.6%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.027 s	-
Agent	iast	1.156 s	129.539 ms (12.6%)
Total	tracing	8.7 s	-
Total	iast	9.325 s	625.643 ms (7.2%)

gantt
    title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~61ad496ab7, baseline=1.56.0-SNAPSHOT~5db793a092

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.472 ms) : 0, 1472
crashtracking [candidate] (1.468 ms) : 0, 1468
BytebuddyAgent [baseline] (711.349 ms) : 0, 711349
BytebuddyAgent [candidate] (699.925 ms) : 0, 699925
GlobalTracer [baseline] (248.013 ms) : 0, 248013
GlobalTracer [candidate] (245.259 ms) : 0, 245259
AppSec [baseline] (32.763 ms) : 0, 32763
AppSec [candidate] (32.37 ms) : 0, 32370
Debugger [baseline] (6.504 ms) : 0, 6504
Debugger [candidate] (6.313 ms) : 0, 6313
Remote Config [baseline] (721.907 µs) : 0, 722
Remote Config [candidate] (683.692 µs) : 0, 684
Telemetry [baseline] (13.78 ms) : 0, 13780
Telemetry [candidate] (9.374 ms) : 0, 9374
Flare Poller [baseline] (7.426 ms) : 0, 7426
Flare Poller [candidate] (10.153 ms) : 0, 10153
section iast
crashtracking [baseline] (1.477 ms) : 0, 1477
crashtracking [candidate] (1.48 ms) : 0, 1480
BytebuddyAgent [baseline] (834.713 ms) : 0, 834713
BytebuddyAgent [candidate] (818.578 ms) : 0, 818578
GlobalTracer [baseline] (235.719 ms) : 0, 235719
GlobalTracer [candidate] (232.992 ms) : 0, 232992
IAST [baseline] (31.884 ms) : 0, 31884
IAST [candidate] (26.659 ms) : 0, 26659
AppSec [baseline] (29.929 ms) : 0, 29929
AppSec [candidate] (35.34 ms) : 0, 35340
Debugger [baseline] (6.046 ms) : 0, 6046
Debugger [candidate] (6.181 ms) : 0, 6181
Remote Config [baseline] (614.957 µs) : 0, 615
Remote Config [candidate] (599.665 µs) : 0, 600
Telemetry [baseline] (8.573 ms) : 0, 8573
Telemetry [candidate] (8.718 ms) : 0, 8718
Flare Poller [baseline] (4.148 ms) : 0, 4148
Flare Poller [candidate] (4.371 ms) : 0, 4371

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	bbujon/doc
git_commit_date	1762881452	1762931828
git_commit_sha	`5db793a`	`61ad496`
release_version	1.56.0-SNAPSHOT~5db793a092	1.55.0-SNAPSHOT~61ad496ab7

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1762933459	1762933459
ci_job_id	1229126314	1229126314
ci_pipeline_id	82042313	82042313
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-1-wdkfnyp3 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-1-wdkfnyp3 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 1 performance improvements and 3 performance regressions! Performance is the same for 9 metrics, 23 unstable metrics.

scenario	Δ mean agg_http_req_duration_p50	Δ mean agg_http_req_duration_p95	Δ mean throughput	candidate mean agg_http_req_duration_p50	candidate mean agg_http_req_duration_p95	candidate mean throughput	baseline mean agg_http_req_duration_p50	baseline mean agg_http_req_duration_p95	baseline mean throughput
scenario:load:petclinic:tracing:high_load	worse [+1.343ms; +4.264ms] or [+3.196%; +10.148%]	worse [+1.485ms; +7.323ms] or [+2.333%; +11.507%]	unstable [-15.023op/s; -0.121op/s] or [-13.563%; -0.110%]	44.826ms	68.042ms	103.188op/s	42.022ms	63.638ms	110.759op/s
scenario:load:petclinic:no_agent:high_load	better [-3.068ms; -0.752ms] or [-8.175%; -2.004%]	same [-3.669ms; +0.560ms] or [-6.381%; +0.975%]	unstable [-4.729op/s; +13.679op/s] or [-3.811%; +11.022%]	35.618ms	55.938ms	128.588op/s	37.528ms	57.492ms	124.112op/s
scenario:load:petclinic:profiling:high_load	worse [+1.296ms; +4.811ms] or [+2.897%; +10.758%]	unstable [-1.081ms; +8.069ms] or [-1.579%; +11.782%]	unstable [-13.519op/s; +0.456op/s] or [-12.911%; +0.436%]	47.772ms	71.980ms	98.177op/s	44.719ms	68.486ms	104.709op/s

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~61ad496ab7, baseline=1.56.0-SNAPSHOT~5db793a092
    dateFormat X
    axisFormat %s
section baseline
no_agent (37.669 ms) : 37358, 37981
.   : milestone, 37669,
appsec (46.255 ms) : 45857, 46654
.   : milestone, 46255,
code_origins (42.998 ms) : 42627, 43369
.   : milestone, 42998,
iast (44.107 ms) : 43731, 44483
.   : milestone, 44107,
profiling (45.236 ms) : 44825, 45647
.   : milestone, 45236,
tracing (42.786 ms) : 42431, 43141
.   : milestone, 42786,
section candidate
no_agent (36.365 ms) : 36070, 36659
.   : milestone, 36365,
appsec (48.109 ms) : 47685, 48532
.   : milestone, 48109,
code_origins (43.309 ms) : 42944, 43673
.   : milestone, 43309,
iast (44.477 ms) : 44107, 44848
.   : milestone, 44477,
profiling (48.267 ms) : 47827, 48708
.   : milestone, 48267,
tracing (45.336 ms) : 44928, 45743
.   : milestone, 45336,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	37.669 ms [37.358 ms, 37.981 ms]	-
appsec	46.255 ms [45.857 ms, 46.654 ms]	8.586 ms (22.8%)
code_origins	42.998 ms [42.627 ms, 43.369 ms]	5.329 ms (14.1%)
iast	44.107 ms [43.731 ms, 44.483 ms]	6.438 ms (17.1%)
profiling	45.236 ms [44.825 ms, 45.647 ms]	7.567 ms (20.1%)
tracing	42.786 ms [42.431 ms, 43.141 ms]	5.117 ms (13.6%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	36.365 ms [36.07 ms, 36.659 ms]	-
appsec	48.109 ms [47.685 ms, 48.532 ms]	11.744 ms (32.3%)
code_origins	43.309 ms [42.944 ms, 43.673 ms]	6.944 ms (19.1%)
iast	44.477 ms [44.107 ms, 44.848 ms]	8.113 ms (22.3%)
profiling	48.267 ms [47.827 ms, 48.708 ms]	11.903 ms (32.7%)
tracing	45.336 ms [44.928 ms, 45.743 ms]	8.971 ms (24.7%)

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~61ad496ab7, baseline=1.56.0-SNAPSHOT~5db793a092
    dateFormat X
    axisFormat %s
section baseline
no_agent (4.365 ms) : 4315, 4415
.   : milestone, 4365,
iast (9.742 ms) : 9579, 9904
.   : milestone, 9742,
iast_FULL (14.983 ms) : 14685, 15281
.   : milestone, 14983,
iast_GLOBAL (10.485 ms) : 10301, 10668
.   : milestone, 10485,
profiling (9.015 ms) : 8863, 9166
.   : milestone, 9015,
tracing (7.78 ms) : 7666, 7895
.   : milestone, 7780,
section candidate
no_agent (4.309 ms) : 4260, 4357
.   : milestone, 4309,
iast (9.344 ms) : 9194, 9493
.   : milestone, 9344,
iast_FULL (14.305 ms) : 14018, 14593
.   : milestone, 14305,
iast_GLOBAL (10.251 ms) : 10070, 10432
.   : milestone, 10251,
profiling (8.974 ms) : 8834, 9113
.   : milestone, 8974,
tracing (7.639 ms) : 7528, 7750
.   : milestone, 7639,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.365 ms [4.315 ms, 4.415 ms]	-
iast	9.742 ms [9.579 ms, 9.904 ms]	5.376 ms (123.2%)
iast_FULL	14.983 ms [14.685 ms, 15.281 ms]	10.618 ms (243.3%)
iast_GLOBAL	10.485 ms [10.301 ms, 10.668 ms]	6.119 ms (140.2%)
profiling	9.015 ms [8.863 ms, 9.166 ms]	4.649 ms (106.5%)
tracing	7.78 ms [7.666 ms, 7.895 ms]	3.415 ms (78.2%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.309 ms [4.26 ms, 4.357 ms]	-
iast	9.344 ms [9.194 ms, 9.493 ms]	5.035 ms (116.9%)
iast_FULL	14.305 ms [14.018 ms, 14.593 ms]	9.997 ms (232.0%)
iast_GLOBAL	10.251 ms [10.07 ms, 10.432 ms]	5.942 ms (137.9%)
profiling	8.974 ms [8.834 ms, 9.113 ms]	4.665 ms (108.3%)
tracing	7.639 ms [7.528 ms, 7.75 ms]	3.33 ms (77.3%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	bbujon/doc
git_commit_date	1762881452	1762931828
git_commit_sha	`5db793a`	`61ad496`
release_version	1.56.0-SNAPSHOT~5db793a092	1.55.0-SNAPSHOT~61ad496ab7

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1762933973	1762933973
ci_job_id	1229126315	1229126315
ci_pipeline_id	82042313	82042313
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-gjfxp9v0 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-gjfxp9v0 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~61ad496ab7, baseline=1.56.0-SNAPSHOT~5db793a092
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.483 ms) : 1472, 1495
.   : milestone, 1483,
appsec (3.728 ms) : 3510, 3947
.   : milestone, 3728,
iast (2.225 ms) : 2161, 2289
.   : milestone, 2225,
iast_GLOBAL (2.265 ms) : 2201, 2329
.   : milestone, 2265,
profiling (2.061 ms) : 2009, 2113
.   : milestone, 2061,
tracing (2.033 ms) : 1983, 2082
.   : milestone, 2033,
section candidate
no_agent (1.479 ms) : 1467, 1490
.   : milestone, 1479,
appsec (3.736 ms) : 3515, 3957
.   : milestone, 3736,
iast (2.214 ms) : 2150, 2278
.   : milestone, 2214,
iast_GLOBAL (2.26 ms) : 2195, 2324
.   : milestone, 2260,
profiling (2.068 ms) : 2015, 2121
.   : milestone, 2068,
tracing (2.04 ms) : 1990, 2090
.   : milestone, 2040,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.483 ms [1.472 ms, 1.495 ms]	-
appsec	3.728 ms [3.51 ms, 3.947 ms]	2.245 ms (151.3%)
iast	2.225 ms [2.161 ms, 2.289 ms]	741.715 µs (50.0%)
iast_GLOBAL	2.265 ms [2.201 ms, 2.329 ms]	782.01 µs (52.7%)
profiling	2.061 ms [2.009 ms, 2.113 ms]	577.861 µs (39.0%)
tracing	2.033 ms [1.983 ms, 2.082 ms]	549.454 µs (37.0%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.479 ms [1.467 ms, 1.49 ms]	-
appsec	3.736 ms [3.515 ms, 3.957 ms]	2.257 ms (152.7%)
iast	2.214 ms [2.15 ms, 2.278 ms]	735.331 µs (49.7%)
iast_GLOBAL	2.26 ms [2.195 ms, 2.324 ms]	781.289 µs (52.8%)
profiling	2.068 ms [2.015 ms, 2.121 ms]	589.261 µs (39.9%)
tracing	2.04 ms [1.99 ms, 2.09 ms]	561.16 µs (38.0%)

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~61ad496ab7, baseline=1.56.0-SNAPSHOT~5db793a092
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.928 s) : 14928000, 14928000
.   : milestone, 14928000,
appsec (15.23 s) : 15230000, 15230000
.   : milestone, 15230000,
iast (18.135 s) : 18135000, 18135000
.   : milestone, 18135000,
iast_GLOBAL (18.02 s) : 18020000, 18020000
.   : milestone, 18020000,
profiling (15.037 s) : 15037000, 15037000
.   : milestone, 15037000,
tracing (14.727 s) : 14727000, 14727000
.   : milestone, 14727000,
section candidate
no_agent (15.438 s) : 15438000, 15438000
.   : milestone, 15438000,
appsec (15.069 s) : 15069000, 15069000
.   : milestone, 15069000,
iast (18.584 s) : 18584000, 18584000
.   : milestone, 18584000,
iast_GLOBAL (17.915 s) : 17915000, 17915000
.   : milestone, 17915000,
profiling (15.172 s) : 15172000, 15172000
.   : milestone, 15172000,
tracing (14.94 s) : 14940000, 14940000
.   : milestone, 14940000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.928 s [14.928 s, 14.928 s]	-
appsec	15.23 s [15.23 s, 15.23 s]	302.0 ms (2.0%)
iast	18.135 s [18.135 s, 18.135 s]	3.207 s (21.5%)
iast_GLOBAL	18.02 s [18.02 s, 18.02 s]	3.092 s (20.7%)
profiling	15.037 s [15.037 s, 15.037 s]	109.0 ms (0.7%)
tracing	14.727 s [14.727 s, 14.727 s]	-201.0 ms (-1.3%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.438 s [15.438 s, 15.438 s]	-
appsec	15.069 s [15.069 s, 15.069 s]	-369.0 ms (-2.4%)
iast	18.584 s [18.584 s, 18.584 s]	3.146 s (20.4%)
iast_GLOBAL	17.915 s [17.915 s, 17.915 s]	2.477 s (16.0%)
profiling	15.172 s [15.172 s, 15.172 s]	-266.0 ms (-1.7%)
tracing	14.94 s [14.94 s, 14.94 s]	-498.0 ms (-3.2%)

docs/how_instrumentations_work.md

sarahchen6

LGTM (from someone who doesn't know the details about bootstrap and premain). All of the context is really helpful!

PerfectSlayer · 2025-10-23T09:58:23Z

LGTM (from someone who doesn't know the details about bootstrap and premain)

Thanks for the review and feedback 🙏
I asked Stuart to have a look. There is no rush so I can leave it open for some days :)

mcculls · 2025-11-10T13:18:59Z

docs/bootstrap_design_guidelines.md

+Code running before the internal logger is configured ([Agent.java line 154](https://github.com/DataDog/dd-trace-java/blob/v1.53.0/dd-java-agent/agent-bootstrap/src/main/java/datadog/trace/bootstrap/Agent.java#L154)) must use `System.err`, not `System.out`, which is reserved for application output:
+
+```java
+System.err.println("Diagnostic message"); // System.error, NOT System.out


Suggested change

System.err.println("Diagnostic message"); // System.error, NOT System.out

System.err.println("Diagnostic message"); // System.err, NOT System.out

mcculls

Looks good, thanks!

feat(doc): Add logging into instrumentation documentation

76a9cb1

PerfectSlayer requested a review from a team as a code owner October 21, 2025 17:44

PerfectSlayer requested a review from ygree October 21, 2025 17:44

PerfectSlayer added the type: documentation label Oct 21, 2025

PerfectSlayer requested a review from mcculls October 21, 2025 17:45

PerfectSlayer added the tag: no release notes Changes to exclude from release notes label Oct 21, 2025

sarahchen6 reviewed Oct 22, 2025

View reviewed changes

docs/how_instrumentations_work.md Outdated Show resolved Hide resolved

sarahchen6 approved these changes Oct 22, 2025

View reviewed changes

PerfectSlayer force-pushed the bbujon/doc branch from f945dbd to 487b8dd Compare October 23, 2025 09:56

mcculls reviewed Nov 10, 2025

View reviewed changes

mcculls approved these changes Nov 10, 2025

View reviewed changes

PerfectSlayer force-pushed the bbujon/doc branch from 487b8dd to b5b282e Compare November 12, 2025 07:16

PerfectSlayer enabled auto-merge (squash) November 12, 2025 07:16

feat(doc): Add bootstrap development guidelines

61ad496

PerfectSlayer force-pushed the bbujon/doc branch from b5b282e to 61ad496 Compare November 12, 2025 07:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add bootstrap development guidelines #9821

Add bootstrap development guidelines #9821

PerfectSlayer commented Oct 21, 2025

Uh oh!

github-actions bot commented Oct 21, 2025

Uh oh!

datadog-datadog-prod-us1 bot commented Oct 21, 2025 •

edited by datadog-official bot

Loading

Uh oh!

pr-commenter bot commented Oct 21, 2025 •

edited

Loading

Uh oh!

Uh oh!

sarahchen6 left a comment

Uh oh!

PerfectSlayer commented Oct 23, 2025

Uh oh!

mcculls Nov 10, 2025

Uh oh!

mcculls left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	System.err.println("Diagnostic message"); // System.error, NOT System.out
	System.err.println("Diagnostic message"); // System.err, NOT System.out

Add bootstrap development guidelines #9821

Are you sure you want to change the base?

Add bootstrap development guidelines #9821

Conversation

PerfectSlayer commented Oct 21, 2025

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

github-actions bot commented Oct 21, 2025

Uh oh!

datadog-datadog-prod-us1 bot commented Oct 21, 2025 • edited by datadog-official bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pr-commenter bot commented Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

Uh oh!

sarahchen6 left a comment

Choose a reason for hiding this comment

Uh oh!

PerfectSlayer commented Oct 23, 2025

Uh oh!

mcculls Nov 10, 2025

Choose a reason for hiding this comment

Uh oh!

mcculls left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

datadog-datadog-prod-us1 bot commented Oct 21, 2025 •

edited by datadog-official bot

Loading

pr-commenter bot commented Oct 21, 2025 •

edited

Loading